Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --humanize and --summarize options for s3 ls #1103

Closed
wants to merge 1 commit into from
Closed

Add --humanize and --summarize options for s3 ls #1103

wants to merge 1 commit into from

Conversation

chadhinton
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 535e86c on chadhinton:humanize into dd3a7e7 on aws:develop.

@jamesls
Copy link
Member

jamesls commented Jan 20, 2015

Thanks for the PR. I think this would be a great addition to the S3 commands. Before this is merged, we just need a few things:

  1. Can you confirm that you are OK with us accepting this under the Apache 2.0 license?
  2. Can you sign our Contributor License Agreement? You can send the signed CLA to the email address in my github profile.

Thanks again for the contribution.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling aedd554 on chadhinton:humanize into dd3a7e7 on aws:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling a396031 on chadhinton:humanize into 4d91f36 on aws:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling efbecb7 on chadhinton:humanize into 4d91f36 on aws:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.76% when pulling eef09d8 on chadhinton:humanize into 4d91f36 on aws:develop.

@jamesls jamesls mentioned this pull request Jan 26, 2015
Merged
@jamesls jamesls closed this in 23b0e69 Jan 26, 2015
@jamesls
Copy link
Member

jamesls commented Jan 26, 2015

Merged via 23b0e69

@chadhinton
Copy link
Contributor Author

Great additions. Agree, binary makes more sense than decimal notation for compatibility. Thanks!

@chadhinton chadhinton deleted the humanize branch April 22, 2015 14:59
@diehlaws diehlaws added pr:work-in-progress This PR is a draft and needs further work. and removed pending labels Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chadhinton @coveralls @jamesls @diehlaws